RE: [PATCH] Speedup truncates of relation forks

Jamison, Kirk <k.jamison@jp.fujitsu.com>

From: "Jamison, Kirk" <k.jamison@jp.fujitsu.com>

To: 'Masahiko Sawada' <sawada.mshk@gmail.com>

Cc: "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, 'Adrien Nayrat' <adrien.nayrat@anayrat.info>

Date: 2019-07-05T03:03:25Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Speedup truncations of relation forks.
- 6d05086c0a79 13.0 landed
Remove unused smgrdounlinkfork() function.
- 33a94bae605e 13.0 landed
Accelerate end-of-transaction dropping of relations
- 279628a0a7cf 9.3.0 cited

Attachments

v4-0001-Speedup-truncates-of-relation-forks.patch (application/octet-stream) patch v4-0001

Hi,

> I updated the patch based from comments, but it still fails the regression
> test as indicated in (5) above.
> Kindly verify if I correctly addressed the other parts as what you intended.
> 
> Thanks again for the review!
> I'll update the patch again after further comments.

I updated the patch which is similar to V3 of the patch,
but addressing my problem in (5) in the previous email regarding FreeSpaceMapVacuumRange.
It seems to pass the regression test now. Kindly check for validation.
Thank you!

Regards,
Kirk Jamison