Horton

Thread

Commits

  1. Fix typos in reloptions.c

  1. Minor fix in reloptions.c comments

    Jamison, Kirk <k.jamison@jp.fujitsu.com> — 2019-04-12T02:41:37Z

    Hi,

I found some minor grammar mistake while reading reloptions.c code comments.
Attached is the fix.
I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
  - * values has no affect until the ...
  + * values has no effect until the ...

Regards,
Kirk Jamison

  2. Re: Minor fix in reloptions.c comments

    Michael Paquier <michael@paquier.xyz> — 2019-04-12T04:00:50Z

    On Fri, Apr 12, 2019 at 02:41:37AM +0000, Jamison, Kirk wrote:
> I found some minor grammar mistake while reading reloptions.c code comments.
> Attached is the fix.
> I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
>   - * values has no affect until the ...
>   + * values has no effect until the ...

A lot of those parameter updates affect processing and still they have
many side effects, as per those paragraphs.

Fixed, thanks!
--
Michael

  3. Re: Minor fix in reloptions.c comments

    Robert Haas <robertmhaas@gmail.com> — 2019-04-15T17:47:16Z

    On Fri, Apr 12, 2019 at 12:01 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Apr 12, 2019 at 02:41:37AM +0000, Jamison, Kirk wrote:
> > I found some minor grammar mistake while reading reloptions.c code comments.
> > Attached is the fix.
> > I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
> >   - * values has no affect until the ...
> >   + * values has no effect until the ...
>
> A lot of those parameter updates affect processing and still they have
> many side effects, as per those paragraphs.

Well, "has no affect" is clearly wrong here, and Kirk's fix is clearly
right.  I don't know what your point here is.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company