Horton

RE: pgbench - doCustom cleanup

Jamison, Kirk <k.jamison@jp.fujitsu.com>

View thread View on postgr.es
From: "Jamison, Kirk" <k.jamison@jp.fujitsu.com>
To: 'Fabien COELHO' <coelho@cri.ensmp.fr>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-04T23:57:55Z
Lists: pgsql-hackers 
Hi Fabien, 

>> See the attached latest patch.
>> The attached patch applies, builds cleanly, and passes the regression 
>> tests.
>
> No problems on my part as I find the changes logical.
> This also needs a confirmation from Alvaro.
>
> Ok.
>
> You switched the patch to "waiting on author": What are you waiting from me?
>
> If you think that it is ok and that it should be considered by a committer,
> probably Alvaro, it can be marked as "ready".

Indeed, it was my mistake.
I have already marked it as "Ready for Committer".

Regards,
Kirk Jamison

Commits

  1. pgbench: doExecuteCommand -> executeMetaCommand

  2. Rework the pgbench state machine code for clarity

  3. instr_time.h: add INSTR_TIME_SET_CURRENT_LAZY

  4. pgbench: introduce a RandomState struct