Thread
-
src/backend/optimizer/util/plancat.c -> Is this correct English
Daniel Westermann (DWE) <daniel.westermann@dbi-services.com> — 2024-09-25T16:52:47Z
Hi, just came across this: src/backend/optimizer/util/plancat.c -> Is this correct English? -> We need not lock the relation since it was already locked ... I am not a native speaker, but this sounds strange. Regards Daniel?
-
Re: src/backend/optimizer/util/plancat.c -> Is this correct English
Nathan Bossart <nathandbossart@gmail.com> — 2024-09-25T16:59:04Z
On Wed, Sep 25, 2024 at 04:52:47PM +0000, Daniel Westermann (DWE) wrote: > just came across this: > > src/backend/optimizer/util/plancat.c -> Is this correct English? > -> We need not lock the relation since it was already locked ... > > I am not a native speaker, but this sounds strange. I think it's fine. It could also be phrased like this: We do not need to lock the relation since... -- nathan
-
Re: src/backend/optimizer/util/plancat.c -> Is this correct English
Daniel Westermann (DWE) <daniel.westermann@dbi-services.com> — 2024-09-25T17:35:48Z
>>I think it's fine. It could also be phrased like this: > > We do not need to lock the relation since... That's what I would have expected. But, as said, maybe this only sounds strange to me. Regards Daniel
-
Re: src/backend/optimizer/util/plancat.c -> Is this correct English
Tom Lane <tgl@sss.pgh.pa.us> — 2024-09-25T17:50:30Z
"Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com> writes: > That's what I would have expected. But, as said, maybe this only sounds strange to me. "Need not" is perfectly good English, although perhaps it has a faintly archaic whiff to it. regards, tom lane