check_function_bodies: At least the description seems wrong, since we have prodedures

Daniel Westermann (DWE) <daniel.westermann@dbi-services.com>

From: "Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-09T12:11:35Z
Lists: pgsql-hackers
Hi,

check_function_bodies has this description: 

postgres=# select short_desc from pg_settings where name = 'check_function_bodies';
                  short_desc                   
-----------------------------------------------
 Check function bodies during CREATE FUNCTION.
(1 row)

This is not the whole truth since we have procedures, as this affects CREATE PROCEDURE as well:

postgres=# create procedure p1 ( a int ) as $$ beginn null; end $$ language plpgsql;
ERROR:  syntax error at or near "beginn"
LINE 1: create procedure p1 ( a int ) as $$ beginn null; end $$ lang...
                                            ^
postgres=# set check_function_bodies = false;
SET
postgres=# create procedure p1 ( a int ) as $$ beginn null; end $$ language plpgsql;
CREATE PROCEDURE
postgres=# 

At least the description should mention procedures. Even the parameter name seems not to be correct anymore. Thoughts?

Regards
Daniel




Commits

  1. Doc: update documentation of check_function_bodies.