Re: [BUG] false positive in bt_index_check in case of short 4B varlena datum
Andrey Borodin <x4mmm@yandex-team.ru>
From: "Andrey M. Borodin" <x4mmm@yandex-team.ru>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Michael Zhilin <m.zhilin@postgrespro.ru>,
pgsql-bugs@postgresql.org,
Yura Sokolov <y.sokolov@postgrespro.ru>
Date: 2024-01-23T18:09:43Z
Lists: pgsql-bugs
Attachments
- v3-0001-contrib-amcheck-must-support-different-header-siz.patch (application/octet-stream) patch v3-0001
- v3-0003-amcheck-avoid-failing-on-oversized-tuples.patch (application/octet-stream) patch v3-0003
- v3-0002-amcheck-prevent-false-positives-from-extended-dat.patch (application/octet-stream) patch v3-0002
> On 20 Jan 2024, at 09:00, Alexander Lakhin <exclusion@gmail.com> wrote: > >> Alexander, do you plan to provide fixes for bugs you discovered? > > No, I don't have a concrete proposal how to fix those bugs. I'd thought > that fixing the whole class of such anomalies, not only one case, is a good > thing to do, but if it's too complicated, maybe other similar bugs could be > put aside. PFA draft fixes for both this errors. Alexander, Michael, Jian, what do you think? I did not touch anything in first step - fix for original bug in this thread. However, I think that comments from Jian He worth incorporating into the fix. Best regards, Andrey Borodin.
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
amcheck: Use correct varlena size accessor in bt_normalize_tuple()
- 4284476c0f67 15 (unreleased) landed
- c89a1ca01344 16 (unreleased) landed
- 8abb8a1555f4 17 (unreleased) landed
- af09b18cbadb 14 (unreleased) landed
- 897e79486296 18 (unreleased) landed
- da1eff08a5be 19 (unreleased) landed