Horton
Menu

Re: Fix logging for invalid recovery timeline

Andrey Borodin <x4mmm@yandex-team.ru>

View thread
From: "Andrey M. Borodin" <x4mmm@yandex-team.ru>
To: David Steele <david@pgbackrest.org>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2024-12-21T04:28:57Z
Lists: pgsql-hackers 

> On 20 Dec 2024, at 20:37, David Steele <david@pgbackrest.org> wrote:
> 
> "Latest checkpoint is at %X/%X on timeline %u, but in the history of the requested timeline, the server forked off from that timeline at %X/%X."

I think errdetai here is very hard to follow. I seem to understand what is going on after reading errmsg, but errdetai makes me uncertain.

If we call "tliSwitchPoint(CheckPointTLI, expectedTLEs, NULL);"
don't we risk to have again
ereport(ERROR,
(errmsg("requested timeline %u is not in this server's history",
tli)));
?

Best regards, Andrey Borodin.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve FATAL message for invalid TLI history at recovery

  2. Fix FATAL message for invalid recovery timeline at beginning of recovery