Re: lippq client library and openssl initialization: PQinitOpenSSL()

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Sebastien Flaesch <sebastien.flaesch@4js.com>, "pgsql-general@lists.postgresql.org" <pgsql-general@lists.postgresql.org>
Date: 2022-09-11T21:43:06Z
Lists: pgsql-general
> On 11 Sep 2022, at 23:35, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 11 Sep 2022, at 17:08, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Don't believe so.  The HAVE_CRYPTO_LOCK stuff is all obsolete and
>>> not compiled if you built against 1.1.0.  The only thing left that
>>> will happen if you don't call PQinitOpenSSL is an extra call to
>>> OPENSSL_init_ssl, which should be harmless as far as I can see
>>> from the OpenSSL docs.
> 
>> To the best of my knowledge, thats entirely correct.
> 
> Should we document these functions as obsolete when using
> OpenSSL >= 1.1.0 ?

Given that 1.1.0+ is very common, it's probably not a bad idea to document them
as obsolete but harmless.  Unless you beat me to it I can propose a patch.

--
Daniel Gustafsson		https://vmware.com/




Commits

  1. doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+