Re: psql - improve test coverage from 41% to 88%
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Paquier <michael@paquier.xyz>,
vignesh C <vignesh21@gmail.com>,
PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
David Steele <david@pgmasters.net>
Date: 2020-08-01T20:42:32Z
Lists: pgsql-hackers
> On 1 Aug 2020, at 09:06, Fabien COELHO <coelho@cri.ensmp.fr> wrote: > > Hello, > >>>> This patch no longer applies: http://cfbot.cputube.org/patch_27_2262.log >>>> >>>> CF entry has been updated to Waiting on Author. >>> >>> This patch hasn't been updated and still doesn't apply, do you intend to rebase >>> it during this commitfest or should we move it to returned with feedback? It >>> can always be re-opened at a later date. >> >> As the thread has stalled, I've marked this Returned with Feedback. > > Hmmm. > > AFAICR the feedback is that the Expect perl module is not welcome, which seems to suggest that it would have to be re-implemented somehow. This is not my dev philosophy, I won't do that, so I'm sorry to say that psql coverage will remain pretty abysmal. Re-reading this thread, I see no complaints about introducing a dependency on Expect. The feedback returned in this case is that the patch hasn't applied since March, and that the patch is more than welcome to be re-entered in the next CF once it does. cheers ./daniel
Commits
-
Improve coverage of psql for backslash commands with \if and \elif
- aafe2762b152 13.0 landed
-
Fix comment in psql's describe.c
- 8a0deae8d9b6 13.0 landed