Re: Fixing WAL instability in various TAP tests

Mark Dilger <mark.dilger@enterprisedb.com>

View thread View on postgr.es

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Noah Misch <noah@leadboat.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-09-27T19:58:28Z

Lists: pgsql-hackers

Attachments

v1-0001-Harden-test-againt-premature-discarding-of-WAL.patch (application/octet-stream) patch v1-0001
v1-0002-Harden-test-againt-premature-discarding-of-WAL.patch (application/octet-stream) patch v1-0002
v1-0003-Harden-and-enable-bloom-TAP-test.patch (application/octet-stream) patch v1-0003
(unnamed) (text/plain)

> On Sep 25, 2021, at 11:04 AM, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
> 
> I took Tom's response to be, "yeah, go ahead", and am mostly waiting for the weekend to be over to see if anybody else has anything to say about it.

Here is a patch set, one patch per test.  The third patch enables its test in the Makefile, which is commented as having been disabled due to the test being unstable in the build farm.  Re-enabling the test might be wrong, since the instability might not have been due to WAL being recycled early.  I didn't find enough history about why that test was disabled, so trying it in the build farm again is the best I can suggest.  Maybe somebody else on this list knows more?

Commits

Fix instability in contrib/bloom TAP tests.
- cf26a8d8a75f 13.5 landed
- cea5624f6a23 14.1 landed
- 6bc6bd47cf71 15.0 landed
- 2d8a8b18fe5a 12.9 landed
Re-enable contrib/bloom's TAP tests.
- 7d1aa6bf1c27 15.0 landed