Re: Fix SPLIT PARTITION bound-overlap bug and other improvements

Chao Li <li.evan.chao@gmail.com>

From: Chao Li <li.evan.chao@gmail.com>

To: Alexander Korotkov <aekorotkov@gmail.com>

Cc: Dmitry Koval <d.koval@postgrespro.ru>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2026-05-17T23:14:30Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Reject degenerate SPLIT PARTITION with DEFAULT partition
- e64a9ba2b4fc 19 (unreleased) landed
- d8af73010033 19 (unreleased) landed
Clarify SPLIT PARTITION bound requirements in docs
- 83df16f1fa5c 19 (unreleased) landed
Fix SPLIT PARTITION hint for DEFAULT partition bounds
- 971017c49599 19 (unreleased) landed
Fix SPLIT PARTITION range bound validation with DEFAULT
- 9354896920e4 19 (unreleased) landed


> On May 18, 2026, at 05:45, Alexander Korotkov <aekorotkov@gmail.com> wrote:
> 
> Hi, Chao!
> 
> On Thu, May 14, 2026 at 9:59 AM Chao Li <li.evan.chao@gmail.com> wrote:
>> To make this patch easier to process, I split it into 4 commits:
>> 
>> 0001 - Fixes the bound-overlap bug
>> 0002 - Fix the incorrect HINT message for the DEFAULT case
>> 0003 - Fix the incorrect description about combined bound in the SGML doc
>> 0004 - Reject only-create-default-partition usage
> 
> Thank you for your work.  I've revised the patchset.
> 0002 - I've also fixed gramma of hints in other branches
> 0004 - In the check_split_partition_not_same_bound(), calling
> partition_bounds_create() and partition_bounds_equal() looks a bit
> heavyweight.  It doesn't matter much performance-wise, but it feels
> like start processing from scratch while we're on quite late stage
> already.  I've replaced that with more lightweight check.  Also I
> removed dealing with memory context.  This code implies small
> non-repetitive memory allocations which only lives during DDL
> operation, no need to wrap them with memory context as we don't do so
> in other places.
> 
> Any objections if I commit this?
> 
> ------
> Regards,
> Alexander Korotkov
> Supabase

Hi Alexander,

Thanks for the revisions. I think you may have missed the attachments, so I cannot review the changes.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/