RE: Proposal for Updating CRC32C with AVX-512 Algorithm.

Amonson, Paul D <paul.d.amonson@intel.com>

From: "Amonson, Paul D" <paul.d.amonson@intel.com>

To: Andres Freund <andres@anarazel.de>

Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Nathan Bossart <nathandbossart@gmail.com>, "Shankaran, Akash" <akash.shankaran@intel.com>

Date: 2024-06-12T21:46:19Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Compute CRC32C using AVX-512 instructions where available
- 3c6e8c123896 18.0 landed

Attachments

0001-v3-Feat-Add-AVX512-crc32c-algorithm-to-postgres.patch (application/octet-stream) patch v3-0001

> -----Original Message-----
> From: Andres Freund <andres@anarazel.de>
> Sent: Wednesday, June 12, 2024 1:12 PM
> To: Amonson, Paul D <paul.d.amonson@intel.com>

> FWIW, I tried the v2 patch on my Xeon Gold 5215 workstation, and dies early
> on with SIGILL:

Nice catch!!!  I was testing the bit for the vpclmulqdq in EBX instead of the correct ECX register. New Patch attached. I added defines to make that easier to see those types of bugs rather than a simple index number. I double checked the others as well.

Paul