Horton

Re: patch: tsearch - some memory diet

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Teodor Sigaev <teodor@sigaev.ru>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQLHackers <pgsql-hackers@postgresql.org>
Date: 2010-10-04T01:08:56Z
Lists: pgsql-hackers 
On Oct 3, 2010, at 7:02 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> It's not at all apparent that the code is even
> safe as-is, because it's depending on the unstated assumption that that
> static variable will get reset once per dictionary.  The documentation
> is horrible: it doesn't really explain what the patch is doing, and what
> it does say is wrong.

Yep. We certainly would need to convince ourselves that this is correct before applying it, and that is all kinds of non-obvious.

...Robert