Horton

Re: DROP OWNED BY fails to clean out pg_init_privs grants

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Hannu Krosing <hannuk@google.com>, Robert Haas <robertmhaas@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Stephen Frost <sfrost@snowman.net>, Andres Freund <andres@anarazel.de>, Noah Misch <nmisch@google.com>
Date: 2024-05-26T21:27:25Z
Lists: pgsql-hackers 
> On 26 May 2024, at 23:25, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Hannu Krosing <hannuk@google.com> writes:
>> Attached is a minimal patch to allow missing roles in REVOKE command
> 
> FTR, I think this is a very bad idea.

Agreed, this is papering over a bug.  If we are worried about pg_upgrade it
would be better to add a check to pg_upgrade which detects this case and
advices the user how to deal with it.

--
Daniel Gustafsson

Commits

  1. Allow meson builds to run test_pg_dump test in installcheck mode.

  2. Remove recordExtensionInitPriv[Worker]'s ownerId argument.

  3. Improve tracking of role dependencies of pg_init_privs entries.

  4. Fix failure to track role dependencies of pg_init_privs entries.

  5. Drop global objects after completed test