Re: COPY FROM performance improvements
Luke Lonergan <llonergan@greenplum.com>
From: "Luke Lonergan" <llonergan@greenplum.com>
To: "Andrew Dunstan" <andrew@dunslane.net>
Cc: "Alvaro Herrera" <alvherre@surnet.cl>, "Bruce Momjian" <pgman@candle.pha.pa.us>, "Alon Goldshuv" <agoldshuv@greenplum.com>, pgsql-patches@postgresql.org
Date: 2005-06-28T04:44:59Z
Lists: pgsql-performance
Attachments
- fast_copy_V14_8.1.patch (application/octet-stream) patch
- pgindent-81.patch (application/octet-stream) patch
Andrew, > Something strange has happened. I suspect that you've inadvertantly used > GNU indent or an unpatched BSD indent. pgindent needs a special patched > BSD indent to work according to the PG standards - see the README OK - phew! I generated new symbols for pgindent and fixed a bug in the awk scripting within (diff attached) and ran against the CVS tip copy.c and got only minor changes in formatting that appear to be consistent with the rest of the code. I pgindent'ed the COPY FROM performance modded code and it looks good and tests good. Only formatting changes to the previous patch for copy.c attached. Patch to update pgindent with new symbols and fix a bug in an awk section (extra \\ in front of a ')'). - Luke