Horton

Re: BUG #17212: pg_amcheck fails on checking temporary relations

Mark Dilger <mark.dilger@enterprisedb.com>

View thread View on postgr.es
From: Mark Dilger <mark.dilger@enterprisedb.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>, Robert Haas <robertmhaas@gmail.com>, Pavel Borisov <pashkin.elfe@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-10-14T21:24:33Z
Lists: pgsql-bugs, pgsql-hackers 

> On Oct 14, 2021, at 2:21 PM, Peter Geoghegan <pg@bowt.ie> wrote:
> 
> I agree. I can go remove the whole file now, and will.
> 
> Mark: Any objections?

None of the "pride of ownership" type, but I would like to see something more about the limitations of background_psql().  It's the closest thing we have to being able to run things in parallel from TAP tests.  There's no isolationtester equivalent, and PostgresNode doesn't allow you to fork() in tests without hacking PostgresNodes END{} block.  So if we don't debug this, we never get any further towards parallel testing from perl.  Or do you have a different way forward for that?

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Remove unstable pg_amcheck tests.

  2. pg_amcheck: avoid unhelpful verification attempts.

  3. amcheck: Skip unlogged relations in Hot Standby.

  4. amcheck: Skip unlogged relations during recovery.