Re: No error checking when reading from file using zstd in pg_dump

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es

From: Daniel Gustafsson <daniel@yesql.se>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Tomas Vondra <tomas@vondra.me>, Evgeniy Gorbanev <gorbanyoves@basealt.ru>, pgsql-hackers@lists.postgresql.org

Date: 2025-06-26T18:01:11Z

Lists: pgsql-hackers

Attachments

v7-0001-Initial-patch-by-Tom-Lane.patch (application/octet-stream) patch v7-0001
v7-0002-pg_dump-compression-API-write_func.patch (application/octet-stream) patch v7-0002
v7-0003-pg_dump-compression-API-open_func.patch (application/octet-stream) patch v7-0003
v7-0004-pg_dump-compression-API-close_func.patch (application/octet-stream) patch v7-0004
v7-0005-pg_dump-compression-API-LZ4Stream_init.patch (application/octet-stream) patch v7-0005
v7-0006-pg_dump-compression-API-read_func-gets_func.patch (application/octet-stream) patch v7-0006

> On 26 Jun 2025, at 15:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> So on the whole I prefer the "void" approach.  I'm not dead
> set on that though, it's just a niggling worry.

I think the likelyhood of it being a problem in practice is pretty slim, but
it's still a stronger argument than my "match an API we're still not aligned
with". The attached v7 reverts back to void return.

--
Daniel Gustafsson

Commits

pg_dump: Fix compression API errorhandling
- ec017a305bd4 16.11 landed
- e686010c5b47 19 (unreleased) landed
- 92268b35d04c 17.7 landed
- 8980c724b559 18.0 landed