Horton

Re: [PATCH] Query Jumbling for CALL and SET utility statements

Sami Imseih <simseih@amazon.com>

View thread View on postgr.es
From: "Imseih (AWS), Sami" <simseih@amazon.com>
To: "Drouvot, Bertrand" <bdrouvot@amazon.com>, "Schneider (AWS), Jeremy" <schnjere@amazon.com>, Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Pavel Stehule <pavel.stehule@gmail.com>, Nikolay Samokhvalov <samokhvalov@gmail.com>
Date: 2022-09-01T15:13:42Z
Lists: pgsql-hackers 
> Please find attached v2 as an attempt to do so.

+1 to the idea.
I think it will be better to evaluate jstate instead of
JUMBLE_UTILITY, such as:

if (query->utilityStmt && !jstate)

instead of

if (query->utilityStmt && !JUMBLE_UTILITY(query->utilityStmt))

This will allow for support of potentially other utility statements
In the future without having to teach pg_stat_statements about them.
If a jstate is set for the utility statements, pgss will do the right thing.


Thanks

--
Sami Imseih
Amazon Web Services (AWS)

Commits

  1. Show values of SET statements as constants in pg_stat_statements

  2. Teach contrib/pg_stat_statements to handle multi-statement commands better.