Horton

Re: smallserial / serial2

Josh Kupershmidt <schmiddy@gmail.com>

View thread
From: Josh Kupershmidt <schmiddy@gmail.com>
To: Brar Piening <brar@gmx.de>
Cc: pgsql-hackers@postgresql.org
Date: 2011-06-10T02:27:41Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add a variant expected-output file for the sequence regression test, to cover

Attachments

On Wed, Jun 8, 2011 at 6:36 PM, Brar Piening <brar@gmx.de> wrote:
> I tried to look at everything and cover everthing but please consider that
> this is my first review so please have a second look at it!

I took a look at this as well, and I didn't encounter any problems
either. The patch is surprisingly small, but it looks like all the
documentation spots got covered, and I didn't see any missing pieces;
pg_dump copes fine, I didn't try pg_upgrade but I wouldn't expect
problems there either.

Actually, the one piece I think could be added is a regression test. I
didn't see any existing tests that covered bigserial/serial8, either,
so I went ahead and added a few tests for smallerial and bigserial. I
didn't see the testcases Brar posted at first, or I might have adopted
a few from there, but this should cover basic use of smallserial.

Josh