Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address
Kohei KaiGai <kaigai@kaigai.gr.jp>
From: Kohei KaiGai <kaigai@kaigai.gr.jp>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@commandprompt.com>,
Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>, PgHacker <pgsql-hackers@postgresql.org>
Date: 2011-06-23T09:51:55Z
Lists: pgsql-hackers
Attachments
- pgsql-v9.2-drop-reworks-part-0.v4.patch (application/octet-stream)
I revised my patch based on your "there-is-no-try-v2.patch". It enabled to implement 'missing_ok' support without modification of orders to solve the object name and relation locking. Thanks, 2011/6/22 Robert Haas <robertmhaas@gmail.com>: > On Wed, Jun 22, 2011 at 12:51 PM, Alvaro Herrera > <alvherre@commandprompt.com> wrote: >> Excerpts from Robert Haas's message of mié jun 22 08:56:02 -0400 2011: >> >>> Another option might be to leave heap_openrv() and relation_openrv() >>> alone and add a missing_ok argument to try_heap_openrv() and >>> try_relation_openrv(). Passing true would give the same behavior as >>> presently; passing false would make them behave like the non-try >>> version. >> >> That would be pretty weird, having two functions, one of them sometimes >> doing the same thing as the other one. >> >> I understand Noah's concern but I think your original proposal was saner >> than both options presented so far. > > I agree with you. If we had a whole pile of options it might be worth > having heap_openrv() and heap_openrv_extended() so as not to > complicate the simple case, but since there's no forseeable need to > add anything other than missing_ok, my gut is to just add it and call > it good. > > -- > Robert Haas > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- KaiGai Kohei <kaigai@kaigai.gr.jp>