Re: psql describe.c cleanup
Merlin Moncure <mmoncure@gmail.com>
From: Merlin Moncure <mmoncure@gmail.com>
To: Josh Kupershmidt <schmiddy@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-06-15T14:01:50Z
Lists: pgsql-hackers
On Tue, Jun 14, 2011 at 9:08 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote: > On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure <mmoncure@gmail.com> wrote: >> What I do wonder though is if the ; appending should really be >> happening in printQuery() instead of in each query -- the idea being >> that formatting for external consumption should be happening in one >> place. Maybe that's over-thinking it though. > > That's a fair point, and hacking up printQuery() would indeed solve my > original gripe about copy-pasting queries out of psql -E. But more > generally, I think that standardizing the style of the code is a Good > Thing, particularly where style issues impact usability (like here). sure -- if anyone would like to comment on this one way or the other feel free -- otherwise I'll pass the patch up the chain as-is...it's not exactly the 'debate of the century' :-). merlin