Re: Use of access(X_OK) check in pg_upgrade

On Wed, May 18, 2011 at 11:41, Bruce Momjian <bruce@momjian.us> wrote:
> I broke the Win32 build members by using access(X_OK) in pg_upgrade.  I
> have a fix for this but looking at pg_upgrade's exec.c, I see for
> Win32:
>
>            if ((buf.st_mode & S_IXUSR) == 0)
>
> I am confused why Windows supports S_IXUSR but not X_OK.

It doesn't natively - we define it in port/win32.h

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/