Re: Unfriendly handling of pg_hba SSL options with SSL off

Magnus Hagander <magnus@hagander.net>

From: Magnus Hagander <magnus@hagander.net>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Bruce Momjian <bruce@momjian.us>, Peter Eisentraut <peter_e@gmx.net>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org

Date: 2011-05-30T18:26:00Z

Lists: pgsql-hackers

Attachments

hba_nolocal.patch (text/x-patch) patch

On Fri, May 13, 2011 at 00:21, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> On Tue, May 10, 2011 at 05:39, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> I wouldn't have a problem with making the Windows port throw an error
>>> for "local" lines.  We'd have to fix initdb to remove that line from the
>>> sample file (if it doesn't already), but that's surely not hard.
>
>> It does already (that's what the @remove-line-for-nolocal@ markup in
>> the sample file is for).
>
>> So +1 for making it throw an error.
>
> Although this should be a simple change, I don't want to do it because
> I'm not in a position to test it.  Do you want to take care of it?

Here's a patch that I think does what we want. It works fine on
Windows - I just want to make sure this is what you meant as well?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/