Horton

Re: FDW table hints

Magnus Hagander <magnus@hagander.net>

View thread
From: Magnus Hagander <magnus@hagander.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dave Page <dpage@pgadmin.org>, Susanne Ebrecht <susanne@2ndquadrant.com>, David Fetter <david@fetter.org>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-05-05T19:48:14Z
Lists: pgsql-hackers 
On Thu, May 5, 2011 at 19:26, Magnus Hagander <magnus@hagander.net> wrote:
> On Thu, May 5, 2011 at 19:22, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Magnus Hagander <magnus@hagander.net> writes:
>>> Since I brought it up - a patch along this line?
>>
>> Please don't capitalize "foreign table" there.
>
> Yeah, I was a bit split about that myself. Will change.
>
>
>> Also, I think an "else" before the other ereport would make the code
>> clearer, even though it's not strictly necessary.
>
> Agreed.
>
> Unless someone objects, I'll go put that in later tonight. (along with
> a comment on why there are two different msgs)
>

Done.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/