Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Allow ALTER TABLE name {OF type | NOT OF}.

  1. pgsql: Allow ALTER TABLE name {OF type | NOT OF}.

    Robert Haas <rhaas@postgresql.org> — 2011-04-21T02:01:43Z

    Allow ALTER TABLE name {OF type | NOT OF}.
    
    This syntax allows a standalone table to be made into a typed table,
    or a typed table to be made standalone.  This is possibly a mildly
    useful feature in its own right, but the real motivation for this
    change is that we need it to make pg_upgrade work with typed tables.
    This doesn't actually fix that problem, but it's necessary
    infrastructure.
    
    Noah Misch
    
    Branch
    ------
    master
    
    Details
    -------
    http://git.postgresql.org/pg/commitdiff/68739ba856c52e6721d6cffec21f1bf0327a9a7b
    
    Modified Files
    --------------
    doc/src/sgml/ref/alter_table.sgml         |   26 +++
    src/backend/commands/tablecmds.c          |  277 +++++++++++++++++++++++++++--
    src/backend/parser/gram.y                 |   17 ++
    src/backend/parser/parse_utilcmd.c        |   22 +---
    src/include/commands/tablecmds.h          |    2 +
    src/include/nodes/parsenodes.h            |    2 +
    src/test/regress/expected/alter_table.out |   38 ++++
    src/test/regress/sql/alter_table.sql      |   30 +++
    8 files changed, 376 insertions(+), 38 deletions(-)
    
    
  2. Re: pgsql: Allow ALTER TABLE name {OF type | NOT OF}.

    Cédric Villemain <cedric.villemain.debian@gmail.com> — 2011-05-27T22:37:05Z

    2011/4/21 Robert Haas <rhaas@postgresql.org>:
    > Allow ALTER TABLE name {OF type | NOT OF}.
    >
    > This syntax allows a standalone table to be made into a typed table,
    > or a typed table to be made standalone.  This is possibly a mildly
    > useful feature in its own right, but the real motivation for this
    > change is that we need it to make pg_upgrade work with typed tables.
    > This doesn't actually fix that problem, but it's necessary
    > infrastructure.
    >
    > Noah Misch
    >
    > Branch
    > ------
    > master
    >
    > Details
    > -------
    > http://git.postgresql.org/pg/commitdiff/68739ba856c52e6721d6cffec21f1bf0327a9a7b
    >
    > Modified Files
    > --------------
    > doc/src/sgml/ref/alter_table.sgml         |   26 +++
    > src/backend/commands/tablecmds.c          |  277 +++++++++++++++++++++++++++--
    
    I noticed 2 warnings on unused variables from gcc in tablecmds.c
    The attached patch fix that by removing those 2 variables.
    
    > src/backend/parser/gram.y                 |   17 ++
    > src/backend/parser/parse_utilcmd.c        |   22 +---
    > src/include/commands/tablecmds.h          |    2 +
    > src/include/nodes/parsenodes.h            |    2 +
    > src/test/regress/expected/alter_table.out |   38 ++++
    > src/test/regress/sql/alter_table.sql      |   30 +++
    > 8 files changed, 376 insertions(+), 38 deletions(-)
    >
    >
    > --
    > Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
    > To make changes to your subscription:
    > http://www.postgresql.org/mailpref/pgsql-committers
    >
    
    
    
    -- 
    Cédric Villemain               2ndQuadrant
    http://2ndQuadrant.fr/     PostgreSQL : Expertise, Formation et Support
    
  3. Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}.

    Alvaro Herrera <alvherre@commandprompt.com> — 2011-05-28T01:53:52Z

    Excerpts from Cédric Villemain's message of vie may 27 18:37:05 -0400 2011:
    > 2011/4/21 Robert Haas <rhaas@postgresql.org>:
    
    > > Modified Files
    > > --------------
    > > doc/src/sgml/ref/alter_table.sgml         |   26 +++
    > > src/backend/commands/tablecmds.c          |  277 +++++++++++++++++++++++++++--
    > 
    > I noticed 2 warnings on unused variables from gcc in tablecmds.c
    > The attached patch fix that by removing those 2 variables.
    
    My compiler wasn't complaining, but since the variable is clearly unused
    I went ahead and pushed this.  Thanks
    
    -- 
    Álvaro Herrera <alvherre@commandprompt.com>
    The PostgreSQL Company - Command Prompt, Inc.
    PostgreSQL Replication, Consulting, Custom Development, 24x7 support
    
    
  4. Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}.

    Cédric Villemain <cedric.villemain.debian@gmail.com> — 2011-05-28T07:05:17Z

    2011/5/28 Alvaro Herrera <alvherre@commandprompt.com>:
    > Excerpts from Cédric Villemain's message of vie may 27 18:37:05 -0400 2011:
    >> 2011/4/21 Robert Haas <rhaas@postgresql.org>:
    >
    >> > Modified Files
    >> > --------------
    >> > doc/src/sgml/ref/alter_table.sgml         |   26 +++
    >> > src/backend/commands/tablecmds.c          |  277 +++++++++++++++++++++++++++--
    >>
    >> I noticed 2 warnings on unused variables from gcc in tablecmds.c
    >> The attached patch fix that by removing those 2 variables.
    >
    > My compiler wasn't complaining, but since the variable is clearly unused
    > I went ahead and pushed this.  Thanks
    
    I have a recent gcc wich probably help here:
    gcc-4.6.real (Debian 4.6.0-7) 4.6.1 20110507 (prerelease)
    
    
    >
    > --
    > Álvaro Herrera <alvherre@commandprompt.com>
    > The PostgreSQL Company - Command Prompt, Inc.
    > PostgreSQL Replication, Consulting, Custom Development, 24x7 support
    >
    
    
    
    -- 
    Cédric Villemain               2ndQuadrant
    http://2ndQuadrant.fr/     PostgreSQL : Expertise, Formation et Support