Re: Fix for Perl 5.14
Alex Hunsaker <badalex@gmail.com>
From: Alex Hunsaker <badalex@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-04-23T16:12:25Z
Lists: pgsql-hackers
Attachments
- ppport.patch.gz (application/x-gzip) patch
On Sat, Apr 23, 2011 at 07:00, Andrew Dunstan <andrew@dunslane.net> wrote: > > > On 04/23/2011 03:02 AM, Alex Hunsaker wrote: >> ... >> There is a minor compile time error due to the API changing a bit: >> plperl.c:929:3: error: lvalue required as left operand of assignment >> ... >> Unfortunately that macro is not available on older perls so the >> attached provides our own macro when GvCV_set is not defined. > How nice of them not to fix it in ppport.h. I thought this is exactly the > sort of thing it's for. Hrm, I have the latest released version of Devel::PPPort, 3.19. I went poking around and found the have a newer "developer" release (3.19_03) at http://search.cpan.org/~mhx/Devel-PPPort-3.19_03/ (released 2011-04-13). I see a few things for 5.14 but nothing about GvCV_set. Maybe I'm doing something wrong? I'm just diffing its ppport.h with ours. For the curious its attached. > This looks OK, but I think we need to wait until they remove the RC tag. Makes sense, Ill repost once they do ;).