Re: creating CHECK constraints as NOT VALID

Simon Riggs <simon@2ndquadrant.com>

From: Simon Riggs <simon@2ndQuadrant.com>

To: Alvaro Herrera <alvherre@commandprompt.com>

Cc: Thom Brown <thom@linux.com>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2011-06-04T13:11:52Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix pg_get_constraintdef to cope with NOT VALID constraints
- 048417511aef 9.1.0 cited

On Thu, Jun 2, 2011 at 5:48 PM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> Excerpts from Alvaro Herrera's message of mié jun 01 20:56:12 -0400 2011:
>> Excerpts from Thom Brown's message of mié jun 01 19:48:44 -0400 2011:
>>
>> > Is this expected?
>> > [ pg_dump fails to preserve not-valid status of constraints ]
>>
>> Certainly not.
>>
>> > Shouldn't the constraint be dumped as not valid too??
>>
>> Sure, I'll implement that tomorrow.
>
> Actually, it turns out that NOT VALID foreign keys were already buggy
> here, and fixing them automatically fixes this case as well, because the
> fix involves touching pg_get_constraintdef to dump the flag.  This also
> gets it into psql's \d.  Patch attached.
>
> (Maybe the changes in psql's describe.c should be reverted, not sure.)

Thanks. As soon as Thom said that, I thought "ahh... didn't do that".

Patch looks fine. Will you commit this patch to 9.1 now, or would you
like me to?

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services