Re: pg_dump vs malloc
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-06-22T15:25:43Z
Lists: pgsql-hackers
Attachments
- pg_dump_malloc.patch (text/x-patch)
On Fri, Jun 10, 2011 at 21:07, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Magnus Hagander <magnus@hagander.net> writes: >> I came across a situation today with a pretty bad crash of pg_dump, >> due to not checking the return code from malloc(). When looking >> through the code, it seems there are a *lot* of places in pg_dump that >> doesn't check the malloc return code. > >> But we do have a pg_malloc() function in there - but from what I can >> tell it's only used very sparsely? > >> Shouldn't we be using that one more or less everywhere > > Yup. Have at it. Something along the line of this? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/