Horton

Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Kohei KaiGai <kaigai@kaigai.gr.jp>
Cc: Noah Misch <noah@leadboat.com>, Alvaro Herrera <alvherre@commandprompt.com>, Tom Lane <tgl@sss.pgh.pa.us>, PgHacker <pgsql-hackers@postgresql.org>
Date: 2011-06-28T01:24:42Z
Lists: pgsql-hackers 
On Mon, Jun 27, 2011 at 4:40 PM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote:
> The attached patch is rebased one towards the latest tree, using
> relation_openrv_extended().

Committed.

> Although it is not a matter in this patch itself, I found a problem on
> the upcoming patch
> that consolidate routines associated with DropStmt.
> Existing RemoveRelations() acquires a lock on the table owning an
> index to be removed
> in the case when OBJECT_INDEX is supplied.
> However, the revised get_object_address() opens the supplied relation
> (= index) in same
> time with lookup of its name. So, we may break down the
> relation_openrv_extended()
> into a pair of RangeVarGetRelid() and relation_open().

Not without looking at the patch.  I will respond on that thread when
I've read through it more thoroughly.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company