Horton

Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <jchampion@timescale.com>, heath.lord@crunchydata.com, pgsql-bugs@lists.postgresql.org
Date: 2022-09-29T21:10:48Z
Lists: pgsql-bugs

Attachments

> On 29 Sep 2022, at 22:45, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> I'll go tweak the documentation as per Daniel's thoughts and push.

Thanks!

Reading a few lines further down in the docs I noticed this description for the
compression parameter to PQsslAttribute:

	"If SSL compression is in use, returns the name of the compression
	algorithm, or "on" if compression is used but the algorithm is not
	known.  If compression is not in use, returns "off"."

AFAICT that has never been the case since 91fa7b4719ac, it has always just
returned "on" or "off" and never the name of the compression algorithm.  I
propose to apply the attached backpatched to make the docs align with the code.

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. Adjust PQsslAttributeNames() to match PQsslAttribute().

  2. doc: Fix PQsslAttribute docs for compression

  3. Fix bogus behavior of PQsslAttribute(conn, "library").

  4. Enable SSL library detection via PQsslAttribute()