Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: chenjq.jy@fujitsu.com,
pgsql-bugs@lists.postgresql.org
Date: 2021-08-17T08:14:18Z
Lists: pgsql-bugs
Attachments
- pg_amcheck_strict_names.diff (application/octet-stream) patch
> On 17 Aug 2021, at 06:34, PG Bug reporting form <noreply@postgresql.org> wrote: > In PG14 beta3, when I use pg_amcheck command, both --no-strict-names > option and --quiet option are specified, the warning message of --database > option is not suppressed. > The official website is described as follows: >> --no-strict-names >> By default, if an argument to --database, --table, --index, or > --relation matches no objects, it is a fatal error. >> This option downgrades that error to a warning. If this option is > used with --quiet, the warning will be suppressed as well. > > When I specify a non-existent database name for the --database option, > and specify the --no-strict-names option and the --quiet option, > pg_amcheck command should not return any message, but it still returns > the warning message. Agreed, in order to match the documentation the attached is required, which also matches other invocations of log_no_match(). This should be applied backpatched to 14 unless there are objections. -- Daniel Gustafsson https://vmware.com/
Commits
-
Remove --quiet option from pg_amcheck
- 9a9c8b92018d 15.0 landed
- 92ce7f527960 14.0 landed