Horton

Re: [Proposal] Global temporary tables

曾文旌 (义从) <wenjing.zwj@alibaba-inc.com>

View thread
From: 曾文旌 <wenjing.zwj@alibaba-inc.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Prabhat Sahu <prabhat.sahu@enterprisedb.com>, tushar <tushar.ahuja@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Konstantin Knizhnik <k.knizhnik@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, "蔡松露(子嘉)" <zijia@taobao.com>, "Cai, Le" <le.cai@alibaba-inc.com>
Date: 2020-07-07T03:47:16Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. PageAddItemExtended(): Add LP_UNUSED assertion.

  2. Remove temporary files after backend crash

  3. Fix comment in indexing.c

  4. Fix failure to ignore leftover temp tables after a server crash.


> 2020年7月6日 下午11:31，Pavel Stehule <pavel.stehule@gmail.com> 写道：
> 
> Hi
> 
> čt 11. 6. 2020 v 4:13 odesílatel 曾文旌 <wenjing.zwj@alibaba-inc.com <mailto:wenjing.zwj@alibaba-inc.com>> napsal:
> 
>> 2020年6月9日 下午8:15，Prabhat Sahu <prabhat.sahu@enterprisedb.com <mailto:prabhat.sahu@enterprisedb.com>> 写道：
>> 
>> 
>> 
>> On Wed, Apr 29, 2020 at 8:52 AM 曾文旌 <wenjing.zwj@alibaba-inc.com <mailto:wenjing.zwj@alibaba-inc.com>> wrote:
>>> 2020年4月27日 下午9:48，Prabhat Sahu <prabhat.sahu@enterprisedb.com <mailto:prabhat.sahu@enterprisedb.com>> 写道：
>>> 
>>> Thanks Wenjing, for the fix patch for previous issues.
>>> I have verified the issues, now those fix look good to me.
>>> But the below error message is confusing(for gtt2).
>>> 
>>> postgres=# drop table gtt1;
>>> ERROR:  cannot drop global temp table gtt1 when other backend attached it.
>>> 
>>> postgres=# drop table gtt2;
>>> ERROR:  cannot drop index idx2 on global temp table gtt2 when other backend attached it.
>>> 
>>> I feel the above error message shown for "DROP TABLE gtt2;" is a bit confusing(looks similar to DROP INDEX gtt2;).
>>> If possible, can we keep the error message simple as "ERROR:  cannot drop global temp table gtt2 when other backend attached it."?
>>> I mean, without giving extra information for the index attached to that GTT.
>> Fixed the error message to make the expression more accurate. In v33.
>>  
>> Thanks Wenjing. We verified your latest patch(gtt_v33) focusing on all reported issues and they work fine. 
>> Thanks.
>> -- 
> 
> I'm very glad to hear such good news.
> I am especially grateful for your professional work on GTT.
> Please feel free to let me know if there is anything you think could be improved.
> 
> 
> Thanks.
> 
> 
> Wenjing
> 
> this patch needs rebase

GTT Merge the latest PGMaster and resolves conflicts.


Wenjing











> 
> Regards
> 
> Pavel
> 
> 
>> With Regards,
>> Prabhat Kumar Sahu
>> EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com/>
>