Re: pg_upgrade check for invalid databases
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Bruce Momjian <bruce@momjian.us>
Cc: Thomas Krennwallner <tk@postsubmeta.net>,
Nathan Bossart <nathandbossart@gmail.com>,
Tom Lane <tgl@sss.pgh.pa.us>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-11-06T15:03:35Z
Lists: pgsql-hackers
> On 1 Nov 2024, at 01:36, Bruce Momjian <bruce@momjian.us> wrote: > On Fri, Oct 25, 2024 at 01:55:57PM +0200, Daniel Gustafsson wrote: >> In the meantime, the OP has a good point that it's a tad silly that pg_upgrade >> fails hard on invalid databases instead of detecting and reporting like how >> other errors are handled. The attached adds this check and expands the report >> wording to cover it. > > Agreed. I've applied this part, the discussion on whether or not pg_upgrade should gain capabilities to skip and/or fix issues should probably be carried over in a new thread. -- Daniel Gustafsson
Commits
-
Find invalid databases during upgrade check stage
- f638aafd1ea8 18.0 landed