Horton

Thread

Commits

  1. psql: Add tab completion for subscription wal_receiver_timeout

  1. psql: add tab completion for subscription wal_receiver_timeout

    Chao Li <li.evan.chao@gmail.com> — 2026-06-24T03:49:26Z

    Hi,

While testing "[fb80f388f] Add per-subscription wal_receiver_timeout setting", I noticed that wal_receiver_timeout is missing from tab completion for both CREATE SUBSCRIPTION WITH and ALTER SUBSCRIPTION SET:
```
evantest=# create subscription ss with (
BINARY                 CREATE_SLOT            FAILOVER               PASSWORD_REQUIRED      SLOT_NAME              TWO_PHASE
CONNECT                DISABLE_ON_ERROR       MAX_RETENTION_DURATION RETAIN_DEAD_TUPLES     STREAMING
COPY_DATA              ENABLED                ORIGIN                 RUN_AS_OWNER           SYNCHRONOUS_COMMIT
evantest=# alter subscription ss set (
BINARY                 FAILOVER               ORIGIN                 RETAIN_DEAD_TUPLES     SLOT_NAME              SYNCHRONOUS_COMMIT
DISABLE_ON_ERROR       MAX_RETENTION_DURATION PASSWORD_REQUIRED      RUN_AS_OWNER           STREAMING              TWO_PHASE
```

This is a tiny patch to fix that.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  2. Re: psql: add tab completion for subscription wal_receiver_timeout

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2026-06-24T05:06:36Z

    Hi,

On Tue, Jun 23, 2026 at 8:50 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
> Hi,
>
> While testing "[fb80f388f] Add per-subscription wal_receiver_timeout setting", I noticed that wal_receiver_timeout is missing from tab completion for both CREATE SUBSCRIPTION WITH and ALTER SUBSCRIPTION SET:
> ```
> evantest=# create subscription ss with (
> BINARY                 CREATE_SLOT            FAILOVER               PASSWORD_REQUIRED      SLOT_NAME              TWO_PHASE
> CONNECT                DISABLE_ON_ERROR       MAX_RETENTION_DURATION RETAIN_DEAD_TUPLES     STREAMING
> COPY_DATA              ENABLED                ORIGIN                 RUN_AS_OWNER           SYNCHRONOUS_COMMIT
> evantest=# alter subscription ss set (
> BINARY                 FAILOVER               ORIGIN                 RETAIN_DEAD_TUPLES     SLOT_NAME              SYNCHRONOUS_COMMIT
> DISABLE_ON_ERROR       MAX_RETENTION_DURATION PASSWORD_REQUIRED      RUN_AS_OWNER           STREAMING              TWO_PHASE
> ```
>
> This is a tiny patch to fix that.

Thanks for the patch.

LGTM.

-- 
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com

  3. Re: psql: add tab completion for subscription wal_receiver_timeout

    Xuneng Zhou <xunengzhou@gmail.com> — 2026-06-24T07:52:04Z

    Hi Evan,

On Wed, Jun 24, 2026 at 11:50 AM Chao Li <li.evan.chao@gmail.com> wrote:
>
> Hi,
>
> While testing "[fb80f388f] Add per-subscription wal_receiver_timeout setting", I noticed that wal_receiver_timeout is missing from tab completion for both CREATE SUBSCRIPTION WITH and ALTER SUBSCRIPTION SET:
> ```
> evantest=# create subscription ss with (
> BINARY                 CREATE_SLOT            FAILOVER               PASSWORD_REQUIRED      SLOT_NAME              TWO_PHASE
> CONNECT                DISABLE_ON_ERROR       MAX_RETENTION_DURATION RETAIN_DEAD_TUPLES     STREAMING
> COPY_DATA              ENABLED                ORIGIN                 RUN_AS_OWNER           SYNCHRONOUS_COMMIT
> evantest=# alter subscription ss set (
> BINARY                 FAILOVER               ORIGIN                 RETAIN_DEAD_TUPLES     SLOT_NAME              SYNCHRONOUS_COMMIT
> DISABLE_ON_ERROR       MAX_RETENTION_DURATION PASSWORD_REQUIRED      RUN_AS_OWNER           STREAMING              TWO_PHASE
> ```
>
> This is a tiny patch to fix that.
>

The patch LGTM. I've verified that SUBOPT_WAL_RECEIVER_TIMEOUT is in
both the CREATE and ALTER supported-option masks.

-- 
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.

  4. Re: psql: add tab completion for subscription wal_receiver_timeout

    Fujii Masao <masao.fujii@gmail.com> — 2026-06-24T08:23:36Z

    On Wed, Jun 24, 2026 at 4:52 PM Xuneng Zhou <xunengzhou@gmail.com> wrote:
> > This is a tiny patch to fix that.
> >
>
> The patch LGTM. I've verified that SUBOPT_WAL_RECEIVER_TIMEOUT is in
> both the CREATE and ALTER supported-option masks.

Thanks for the patch! LGTM.

Since wal_receiver_timeout subscription option is new in v19, I'm thinking
to commit this to v19 rather than v20.

Regards,

-- 
Fujii Masao

  5. Re: psql: add tab completion for subscription wal_receiver_timeout

    Chao Li <li.evan.chao@gmail.com> — 2026-06-24T08:30:46Z

    
> On Jun 24, 2026, at 16:23, Fujii Masao <masao.fujii@gmail.com> wrote:
> 
> On Wed, Jun 24, 2026 at 4:52 PM Xuneng Zhou <xunengzhou@gmail.com> wrote:
>>> This is a tiny patch to fix that.
>>> 
>> 
>> The patch LGTM. I've verified that SUBOPT_WAL_RECEIVER_TIMEOUT is in
>> both the CREATE and ALTER supported-option masks.
> 
> Thanks for the patch! LGTM.
> 
> Since wal_receiver_timeout subscription option is new in v19, I'm thinking
> to commit this to v19 rather than v20.

I think so.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  6. Re: psql: add tab completion for subscription wal_receiver_timeout

    Fujii Masao <masao.fujii@gmail.com> — 2026-06-24T14:02:04Z

    On Wed, Jun 24, 2026 at 5:31 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
>
>
> > On Jun 24, 2026, at 16:23, Fujii Masao <masao.fujii@gmail.com> wrote:
> >
> > On Wed, Jun 24, 2026 at 4:52 PM Xuneng Zhou <xunengzhou@gmail.com> wrote:
> >>> This is a tiny patch to fix that.
> >>>
> >>
> >> The patch LGTM. I've verified that SUBOPT_WAL_RECEIVER_TIMEOUT is in
> >> both the CREATE and ALTER supported-option masks.
> >
> > Thanks for the patch! LGTM.
> >
> > Since wal_receiver_timeout subscription option is new in v19, I'm thinking
> > to commit this to v19 rather than v20.
>
> I think so.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao

  7. Re: psql: add tab completion for subscription wal_receiver_timeout

    Chao Li <li.evan.chao@gmail.com> — 2026-06-25T06:14:35Z

    
> On Jun 24, 2026, at 22:02, Fujii Masao <masao.fujii@gmail.com> wrote:
> 
> On Wed, Jun 24, 2026 at 5:31 PM Chao Li <li.evan.chao@gmail.com> wrote:
>> 
>> 
>> 
>>> On Jun 24, 2026, at 16:23, Fujii Masao <masao.fujii@gmail.com> wrote:
>>> 
>>> On Wed, Jun 24, 2026 at 4:52 PM Xuneng Zhou <xunengzhou@gmail.com> wrote:
>>>>> This is a tiny patch to fix that.
>>>>> 
>>>> 
>>>> The patch LGTM. I've verified that SUBOPT_WAL_RECEIVER_TIMEOUT is in
>>>> both the CREATE and ALTER supported-option masks.
>>> 
>>> Thanks for the patch! LGTM.
>>> 
>>> Since wal_receiver_timeout subscription option is new in v19, I'm thinking
>>> to commit this to v19 rather than v20.
>> 
>> I think so.
> 
> I've pushed the patch. Thanks!
> 
> Regards,
> 
> -- 
> Fujii Masao

Thanks a lot for pushing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/