Re: GUC for temporarily disabling event triggers
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
Tom Lane <tgl@sss.pgh.pa.us>,
Justin Pryzby <pryzby@telsasoft.com>,
Mikhail Gribkov <youzhick@gmail.com>,
pgsql-hackers@lists.postgresql.org
Date: 2023-09-06T08:50:46Z
Lists: pgsql-hackers
Attachments
- v7-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch (application/octet-stream) patch v7-0001
> On 5 Sep 2023, at 17:29, Robert Haas <robertmhaas@gmail.com> wrote: > On Tue, Sep 5, 2023 at 8:12 AM Daniel Gustafsson <daniel@yesql.se> wrote: >> The attached version of the patch replaces it with a boolean flag for turning >> off all event triggers, and I also renamed it to the debug_xxx "GUC namespace" >> which seemed more appropriate. > > I don't care for the debug_xxx renaming, myself. I think that should > be reserved for things where we believe there's no reason to ever use > it in production/real life, or for things whose purpose is to emit > debugging messages. Neither is the case here. Fair enough, how about disable_event_trigger instead as per the attached? -- Daniel Gustafsson
Commits
-
Add GUC for temporarily disabling event triggers
- 7750fefdb2b8 17.0 landed
-
Fix typos in code and comments
- 5f6401f81cb2 16.0 cited