Re: [PATCH] GROUP BY ALL
Chao Li <li.evan.chao@gmail.com>
From: Chao Li <li.evan.chao@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>,
David Christensen <david@pgguru.net>,
Andrey Borodin <x4mmm@yandex-team.ru>,
pgsql-hackers <pgsql-hackers@postgresql.org>,
"David G. Johnston" <david.g.johnston@gmail.com>,
Jelte Fennema-Nio <postgres@jeltef.nl>
Date: 2025-09-28T09:05:04Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Add GROUP BY ALL.
- ef38a4d9756d 19 (unreleased) landed
-
Refactor to avoid code duplication in transformPLAssignStmt.
- b0fb2c6aa5a4 19 (unreleased) landed
-
Fix missed copying of groupDistinct in transformPLAssignStmt.
- b7f6798c056a 16.11 landed
- 9ca79896aba3 15.15 landed
- 78a284b0b8d4 18.1 landed
- 7504d2be9eb4 19 (unreleased) landed
- 3fc9aa5b0233 17.7 landed
- 0be39b4b1a01 14.20 landed
> On Sep 28, 2025, at 06:23, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> + /* Iterate over targets, adding acceptable ones to the result list */
> + foreach_ptr(TargetEntry, tle, *targetlist)
> + {
> + /* Ignore junk TLEs */
> + if (tle->resjunk)
> + continue;
Do we want to specifically check “ctid”?
If a user does:
```
select ctid, col1, col2, ... from t group by all;
```
It would be equivalent to no group by. Combing “select ctid” with “group by all” seems totally useless, but when users do such things, we can optimize that.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/