Re: Bug in pg_get_aios()

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@lists.postgresql.org
Date: 2026-03-23T15:50:18Z
Lists: pgsql-hackers
Hi, 

On March 23, 2026 4:44:21 AM EDT, Michael Paquier <michael@paquier.xyz> wrote:
>On Mon, Mar 23, 2026 at 02:30:28PM +0800, Chao Li wrote:
>>> On Mar 23, 2026, at 14:23, cca5507 <cca5507@qq.com> wrote:
>>> If I understand correctly, we want to set nulls[0] to true if owner_pid equals to 0:
>> 
>> Indeed an obvious bug.
>
>Or the intention of the code could have been to allow a PID value of 0
>to be exposed, but I don't really buy it.

That certainly wasn't the intent :).

I suspect this is unreachable, we wait for ios before exiting, but of course that doesn't excuse broken code.


>Will fix, thanks for the report.

Thanks! 

Andres


-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.



Commits

  1. Fix invalid value of pg_aios.pid, function pg_get_aios()