Horton

Re: [PATCH] Enable SSL library detection via PQsslAttribute

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Jacob Champion <pchampion@vmware.com>
Cc: "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>, "andrew@dunslane.net" <andrew@dunslane.net>, "robertmhaas@gmail.com" <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2022-03-28T20:33:57Z
Lists: pgsql-hackers 
> On 25 Mar 2022, at 23:45, Jacob Champion <pchampion@vmware.com> wrote:
> 
> On Fri, 2022-03-25 at 18:00 -0400, Tom Lane wrote:
>> Jacob Champion <pchampion@vmware.com> writes:
>>> Do I need to merge my tiny test program into the libpq_pipeline tests?
>> 
>> Doesn't seem worth the trouble to me, notably because you'd
>> then have to cope with non-SSL builds too.
> 
> Fine by me.
> 
> v5 moves the docs out of the Note, as requested by Daniel.

I went over this again and I think this version is ready for committer.  Having
tried to add implement a new TLS library I would add a small comment on
PQsslAttributeNames() for this, reverse-engineering what to implement is hard
as it is without special cases easily identifiable.  That can easily be done
when pushed, no need for a new version IMHO.

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. Enable SSL library detection via PQsslAttribute()