Horton

pg_dumpall with flag --no-role-passwords omits roles comments as well

Bartosz Chroł <bartosz.chrol@handen.pl>

View thread View on postgr.es
From: Bartosz Chroł <bartosz.chrol@handen.pl>
To: "pgsql-general@postgresql.org" <pgsql-general@postgresql.org>
Date: 2024-03-20T17:40:55Z
Lists: pgsql-general 
Hello,
I've tried to dump roles using the following call to pg_dumpall:
pg_dumpall.exe --roles-only --no-role-passwords
However I noticed that comments on roles are also omitted from the dump, as if --no--comments flag was set - but it wasn't.
When I call `pg_dumpall.exe --roles-only` than it works as expected - both passwords and comments are dumped.

Is it correct behaviour? It doesn't look like to me, but maybe I'm missing something. I've checked PostgreSQL 16.2 (on Windows 11 and Ubuntu 20) and 14.0 (on Windows Server 2019), same everywhere.

Best regards
Bartek

Commits

  1. Fix dumping role comments when using --no-role-passwords