Thread

Redundant initialization of table AM oid in relcache

Jingtang Zhang <mrdrivingduck@gmail.com> — 2024-11-21T04:06:03Z

Hi~

Just found 'relam' field is assigned twice during relcache initialization. We
have a specific area for initialization AM related stuff several lines later:

> 	/*
> 	 * initialize the table am handler
> 	 */
> 	relation->rd_rel->relam = HEAP_TABLE_AM_OID;
> 	relation->rd_tableam = GetHeapamTableAmRoutine();



so previous assignment seems not needed and can be removed.


—

Regards, Jingtang