Re: pg_rewind copies
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: David Steele <david@pgmasters.net>,
Cary Huang <cary.huang@highgo.ca>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-09T13:11:51Z
Lists: pgsql-hackers
> On 25 Mar 2021, at 14:32, David Steele <david@pgmasters.net> wrote: > > On 1/22/21 8:26 AM, Heikki Linnakangas wrote: >> On 16/12/2020 00:08, Cary Huang wrote: >>> The following review has been posted through the commitfest application: >>> make installcheck-world: tested, passed >>> Implements feature: tested, passed >>> Spec compliant: tested, passed >>> Documentation: not tested >>> >>> Hello >>> >>> The patch seems to do as described and the regression and tap tests are passing >>> + /* >>> + * A local source is not expected to change while we're rewinding, so check >>> + * that we size of the file matches our earlier expectation. >>> + */ >>> Is this a tyoo? >> Yep, thanks! Attached is a new patch version, with that fixed and rebased. No other changes. > > Cary, does this patch look ready to commit? If so, please change the state in the CF entry to "Ready for Committer". Reading the patch I think it definitely qualifies for RFC state. Heikki, do you have plans to address till patch in the ongoing CF? -- Daniel Gustafsson https://vmware.com/
Commits
-
pg_rewind: Fetch small files according to new size.
- 16915126746e 15.0 landed