Horton

Re: Converting pqsignal to void return

Paul Ramsey <pramsey@cleverelephant.ca>

View thread
From: Paul Ramsey <pramsey@cleverelephant.ca>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Nathan Bossart <nathandbossart@gmail.com>
Date: 2025-01-22T17:01:09Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Convert libpgport's pqsignal() to a void function.

  2. Check that MyProcPid == getpid() in backend signal handlers.


> On Jan 22, 2025, at 8:50 AM, Andres Freund <andres@anarazel.de> wrote:
> 
>> It is possible we have been Doing It Wrong all this time, and would love some pointers on the right way to do this.
> 
> All your interrupt handler is doing "for you" is setting
> http_interrupt_requested, right?  Why do you need that variable? Seems you
> could just check postgres' QueryCancelPending? And perhaps ProcDiePending, if
> you want to handle termination too.

This is the Knowledge that was sitting right in front of me, but I could not see.
From the road to Damascus,
Paul