Re: add timing information to pg_upgrade

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Nathan Bossart <nathandbossart@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-08-01T07:58:24Z
Lists: pgsql-hackers
> On 1 Aug 2023, at 09:45, Peter Eisentraut <peter@eisentraut.org> wrote:
> On 28.07.23 01:51, Nathan Bossart wrote:

>> This information can be used to better understand where the time is going
>> and to validate future improvements.
> 
> But who would use that, other than, you know, you, right now?
> 
> I think the pg_upgrade output is already too full with not-really-actionable information (like most of the above "Checking ..." are not really interesting for a regular user).

Maybe if made opt-in with a --debug option, or even a compiler option for
enabling only in specialized debugging builds?

--
Daniel Gustafsson




Commits

  1. pg_upgrade: Bump MESSAGE_WIDTH.