Horton
Menu

Re: Fix number skipping in to_number

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Oliver Ford <ojford@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@enterprisedb.com>, Nathan Wagner <nw+pg@hydaspes.if.org>
Date: 2017-10-02T12:24:41Z
Lists: pgsql-hackers 
> On 25 Sep 2017, at 02:52, Nathan Wagner <nw+pg@hydaspes.if.org> wrote:
> 
> On Thu, Aug 17, 2017 at 12:33:02PM +0100, Oliver Ford wrote:
> 
>> Ok I've made that change in the attached v3. I'm not sure as I'm on
>> en_US.UTF-8 locale too. Maybe something Windows specific?
> 
> This patch applies against master (8485a25a), compiles, and
> passes a make check.
> 
> I tested both on my mac laptop, and my linux server.
> 
> If we want this patch, I'd say it's ready for committer.  We may want
> (and I can't believe I'm saying this) more discussion as to exactly what
> the strategy for to_number() (and friends) is.

Based on this review, I am moving this patch to the next commitfest and will
update it to Ready for committer.  There might, as you say, be more discussion
needed, but due to the lack of extensive such so far I’ll move it for now.

cheers ./daniel

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve to_date/to_number/to_timestamp behavior with multibyte characters.

  2. Prevent to_number() from losing data when template doesn't match exactly.