Re: IPC::Run::time[r|out] vs our TAP tests

> On 19 Feb 2025, at 23:08, Andrew Dunstan <andrew@dunslane.net> wrote:
> On 2024-10-31 Th 6:18 PM, Heikki Linnakangas wrote:

Thanks for review!

>> Perhaps sommething like this:
>> 
>> "Close the psql session and clean up resources. Each psql session must be closed with C<quit> before the end of the test.
>> Returns TRUE if psql exited successfully (i.e. with zero exit code), otherwise returns FALSE and reports a test failure."
>> 
>> Would that be accurate?
> 
> I would be OK with Heikki's version.

Fixed.

> The patches have bitrotted slightly.

The attached rebases over current HEAD and passes check-world locally for me.

> Also this is wrong, I think:
> 
>     isnt($self->{timeout}->is_expired, 'psql query_until timed out');
> 
> I think it should be
> 
>     ok(! $self->{timeout}->is_expired, 'psql query_until did not time out');

Fixed.

--
Daniel Gustafsson