Re: max_standby_delay considered harmful
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Josh Berkus <josh@agliodbs.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>, Simon Riggs <simon@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, Florian Pflug <fgp@phlo.org>, Dimitri Fontaine <dfontaine@hi-media.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org, Bruce Momjian <bruce@momjian.us>, Greg Smith <greg@2ndquadrant.com>
Date: 2010-05-14T21:32:15Z
Lists: pgsql-hackers
On Thu, May 13, 2010 at 1:12 PM, Josh Berkus <josh@agliodbs.com> wrote: > On 5/12/10 8:07 PM, Robert Haas wrote: >> I think that would be a good thing to check (it'll confirm whether >> this is the same bug), but I'm not convinced we should actually fix it >> that way. Prior to 8.4, we handled a smart shutdown during recovery >> at the conclusion of recovery, just prior to entering normal running. >> I'm wondering if we shouldn't revert to that behavior in both 8.4 and >> HEAD. > > This would be OK as long as we document it well. We patched the > shutdown the way we did specifically because Fujii thought it would be > an easy fix; if it's complicated, we should revert it and document the > issue for DBAs. I don't understand this comment. > Oh, and to confirm: the same issue exists, and has always existed, with > Warm Standby. That's what I was thinking, but I hadn't gotten around to testing it. Thanks for the confirmation. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company