Re: [v9.1] add makeRangeTblEntry() into makefuncs.c

2010/6/14 KaiGai Kohei <kaigai@ak.jp.nec.com>:
> The attached patch was a part of DML refactoring and security hook patches.
>
> It adds makeRangeTblEntry() into makefuncs.c to keep the code more
> clean. It shall be also used for the upcoming DML refactor patch.
> In this refactoring, a common DML permission checker function take
> a list of RangeTblEntry, so the caller has to set up the object.

I think this is the epitome of pointless.  It looks to me like this
just makes the code harder to read and very slightly slower without
actually accomplishing any useful abstraction.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company