Re: pgsql: Allow copydir() to be interrupted.
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Robert Haas <rhaas@postgresql.org>, pgsql-committers <pgsql-committers@postgresql.org>
Date: 2010-07-02T13:19:23Z
Lists: pgsql-hackers
On Fri, Jul 2, 2010 at 2:13 PM, Robert Haas <robertmhaas@gmail.com> wrote: > On Fri, Jul 2, 2010 at 8:10 AM, Andrew Dunstan <andrew@dunslane.net> wrote: >> Robert Haas wrote: >>> Log Message: >>> ----------- >>> Allow copydir() to be interrupted. >>> >> >> This appears to have broken MinGW and Cygwin builds on the buildfarm. > > Well, that's not awesome. IM-ing with Magnus now. I'm wondering if > this is a link-ordering problem of some kind. We've seen something like this before, but I don't recall what it was. It's probably something getting resolved too early when it's built into libpgport_srv.a. That would explain why it's working fine on MSVC - we don't actually bother building a server-side .lib there, we just link the object files directly into postgres.exe. (We do build the library for client side, of course, since it's used in many different binaries) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/