Horton
Menu

Re: InvalidXLogRecPtr in docs

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>, pgsql-hackers@postgresql.org
Date: 2010-06-10T06:42:35Z
Lists: pgsql-hackers

Attachments

On Thu, Jun 10, 2010 at 11:56 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Wed, Jun 9, 2010 at 9:46 PM, Takahiro Itagaki
>> <itagaki.takahiro@oss.ntt.co.jp> wrote:
>>> I found a term "InvalidXLogRecPtr" in 9.0 docs.
>>> http://developer.postgresql.org/pgdocs/postgres/functions-admin.html#FUNCTIONS-RECOVERY-INFO-TABLE
>>> | ... then the return value will be InvalidXLogRecPtr (0/0).
>
>> Maybe we should be returning NULL instead of 0/0.
>
> +1 for using NULL instead of an artificially chosen value, for both of
> those functions.

Okay, the attached patch makes those functions return NULL in that case.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center