Horton

Re: why does plperl cache functions using just a bool for is_trigger

Greg Stark <gsstark@mit.edu>

View thread
From: Greg Stark <gsstark@mit.edu>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jan Urbański <wulczer@wulczer.org>, Hannu Krosing <hannu@2ndquadrant.com>, Alex Hunsaker <badalex@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, Postgres - Hackers <pgsql-hackers@postgresql.org>
Date: 2010-11-08T17:36:39Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove unnecessary use of trigger flag to hash plperl functions

On Fri, Nov 5, 2010 at 2:56 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> It's not cheap :-( ... but it's *necessary*.  There's no other way to
> get sane behavior.
>
> If the cost annoys you, you should put some effort into making subxact
> start/stop cheaper overall, rather than trying to avoid having one here.

I would be pretty happy even if only the *first* subxact was cheap.
That would take care of 99% of use implicit use cases leaving mostly
only cases where users have explicitly asked for a subxact with a
catch/throw block.

In particular it would cover the psql case of wanting to have a
subxact around every interactive command so the user can hit C-c
without undoing their whole transaction.

-- 
greg